Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config domains with either method or attribute domain_name #3159

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

This is a follow-on to #3126 where we were defining functor domain validators just to be able to define the domain_name method. This simple fix supports retrieving the domain name as either an attribute, property, or method.

Changes proposed in this PR:

  • Support specifying a custom domain name as either a domain_name attribute or method

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b4ea7d) 88.38% compared to head (41d8197) 88.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   88.38%   88.37%   -0.01%     
==========================================
  Files         846      846              
  Lines       94827    94830       +3     
==========================================
- Hits        83811    83806       -5     
- Misses      11016    11024       +8     
Flag Coverage Δ
linux 86.32% <100.00%> (+<0.01%) ⬆️
osx 75.74% <100.00%> (+<0.01%) ⬆️
other 86.52% <100.00%> (-0.01%) ⬇️
win 83.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit a4dc0c2 into Pyomo:main Feb 22, 2024
33 checks passed
@jsiirola jsiirola deleted the config-domain branch February 28, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants