Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHTracking extension #334

Merged
merged 14 commits into from
Sep 10, 2023
Merged

PHTracking extension #334

merged 14 commits into from
Sep 10, 2023

Conversation

garg02
Copy link
Contributor

@garg02 garg02 commented Sep 8, 2023

This PR is 98% independent of #333, but until sending hub bounds to spoke is finalized, convergence tracking that require hub bounds won't work. I have disabled the specific tracking args in cfg_vanilla.py so the tests will run fine.

Notes of changes that have been made by file
phtracker.py:

  • Implemented tracking as an extension;
  • As some of the tracking code (bounds and nonants) could be used for other optimizers besides PH, maybe we should make subclasses of TrackedData for each type. Thoughts?

cfg_vanilla:

  • Used extension_adder to simplify the process of bridging command line arguments with ph options

farmer_cylinders.py:

  • using extension_adder so extensions can also be added from cfg_vanilla

primal_dual_converger.py

  • Implemented tracking

lagranger_bounder.py and lagrangian_bounder.py

  • initialize iteration variable earlier so tracker can access
  • call extensions post_loops()

converger.py, extension.py, phbase.py, and spopt.py

  • added hooks to call extension and converger methods

config.py

  • added command line arguments to use wxbar reader and writer and PHTracker

examples/run_all.py

  • testing changes

@DLWoodruff DLWoodruff merged commit 28ea4ee into Pyomo:main Sep 10, 2023
@garg02 garg02 deleted the tracking branch September 13, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants