Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate AcceptCharsetXXXHeader classes into the single AcceptCharset class #461

Open
wants to merge 1 commit into
base: simplify-accept-parsing
Choose a base branch
from
Open

consolidate AcceptCharsetXXXHeader classes into the single AcceptCharset class #461

wants to merge 1 commit into from

Conversation

mmerickel
Copy link
Member

@mmerickel mmerickel commented Mar 1, 2024 •
edited
Loading

  • Ensure AcceptCharset instances are immutable.
  • Merge missing/invalid/valid into the single instance - there were very very minor differences between the classes.
  • Delete deprecated __iter__.
  • Reimplement best_match, quality, and __contains__ methods using acceptable_offers.

@mmerickel mmerickel force-pushed the simplify-accept-charset-parsing branch 2 times, most recently from 0c4c846 to 2bcc46d Compare March 1, 2024 05:39
@mmerickel mmerickel marked this pull request as ready for review March 1, 2024 05:39
@mmerickel mmerickel force-pushed the simplify-accept-parsing branch 4 times, most recently from 7a5e3ce to b0b14d7 Compare March 1, 2024 06:44
@mmerickel mmerickel force-pushed the simplify-accept-charset-parsing branch 2 times, most recently from 03969e2 to c586619 Compare March 1, 2024 07:02
@mmerickel mmerickel changed the title consolidate accept classes into the single AcceptCharset class consolidate Accept-Charset classes into the single AcceptCharset class Mar 2, 2024
@mmerickel mmerickel changed the title consolidate Accept-Charset classes into the single AcceptCharset class consolidate AcceptCharsetXXXHeader classes into the single AcceptCharset class Mar 2, 2024
@mmerickel mmerickel force-pushed the simplify-accept-parsing branch 2 times, most recently from 872755d to 33ee697 Compare March 2, 2024 20:19
@mmerickel mmerickel force-pushed the simplify-accept-charset-parsing branch 2 times, most recently from f7e1fcd to 7359d70 Compare March 2, 2024 20:54
@mmerickel mmerickel force-pushed the simplify-accept-parsing branch from 33ee697 to af05bfd Compare March 2, 2024 21:32
@mmerickel mmerickel force-pushed the simplify-accept-charset-parsing branch from 7359d70 to 6fc063e Compare March 2, 2024 21:34
@mmerickel mmerickel force-pushed the simplify-accept-parsing branch from af05bfd to 36171cb Compare March 4, 2024 00:54
@mmerickel mmerickel force-pushed the simplify-accept-charset-parsing branch from 6fc063e to 0afa9f2 Compare March 4, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmerickel