Feature: Accept.best_client_match #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flips the logic from best_match on it's head, in that it allows the client to dictate what should be returned given a multitude of server offerings. With an accept header of: application/json, text/html, */*;q=0.8 And a server offer of: text/html, application/json The best match returned will be 'application/json'. This makes a lot of sense in other contexts too, for instance if the browser had a specific ordering it wanted images in: image/webp, image/jpeg, image/gif, image/*;q=0.9 If the server offered up image/gif, image/jpeg with best_match this would return image/gif, with best_client_match, this would return image/jpeg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this comment: #239 (comment)
This adds a new
best_client_matchfunction that allows the client to define the order in which things are returned. This does the opposite ofbest_matchwhich currently considers the server's offers in order, and as long as the client will accept it, it sends the servers preferred answer.