Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use '\r\n' line endings in Response.__str__. #146

Merged
merged 1 commit into from
Apr 14, 2015
Merged

Use '\r\n' line endings in Response.__str__. #146

merged 1 commit into from
Apr 14, 2015

Conversation

lrowe
Copy link
Contributor

@lrowe lrowe commented Apr 16, 2014

Response headers should have CRLF line endings the same as Request headers. http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.2

@mgeisler
Copy link

I wanted to use a Response instance for some hand-coded HTTP responses and was surprised to see \n separated lines. So yes, this looks correct and I think it should be merged.

@digitalresistor digitalresistor added this to the Version 1.5 milestone Mar 23, 2015
@digitalresistor digitalresistor merged commit 3ab11fd into Pylons:master Apr 14, 2015
@pyup-bot pyup-bot mentioned this pull request Jan 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@lrowe @mgeisler @digitalresistor