Fix bug that caused slow requests to block the processing of other concurrent requests #1
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncurrent requests.
|
Ha, I just finished writing very similar code, checked in as 7fa8ef4 . Thanks for this though! |
|
Fixed by commit #7fa8ef4d9410b83237dfd11f0700d3117eeb9b27 |
This was referenced Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the mailing-list (http://groups.google.com/group/pylons-discuss/browse_thread/thread/1939cb1012e2190f), any request will block Waitress, which means that other concurrent requests will not be processed until the previous one has returned.
The attached changes provide a possible fix and a test. I do not know whether this change has negative side effects (but other tests still pass so we could pretend that nothing has been broken ;) ).