avoid touching the session except when the user already touched it #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
fix/avoid-touching-session
branch
3 times, most recently
from
9d34fe5 to
04ea930
Compare
mmerickel
force-pushed
the
fix/avoid-touching-session
branch
from
04ea930 to
158522f
Compare
This was referenced Feb 26, 2017
This was referenced Mar 12, 2017
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids touching the session unless the user accesses it. It's deliciously evil and dependent on the session being reified such that it's only called once.
The benefit of this approach is that the session is snapshotted on ingress, prior to any changes made by the user.