Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of repeated POST vars #210

Merged
merged 1 commit into from
Mar 11, 2015

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Feb 13, 2015

The keys for POST vars with duplicate names were being (correctly) listed in their orignal order, however all values for each of these keys were (incorrectly) listed for each occurance of the duplicated keys.

This is particularly confusing, e.g., when looking at, e.g. peppercorn-encoded data. By way of example, currently peppercorn data consisting of two simple mappings is currently (incorrectly) displayed as:

Variable Value
start u'A:mapping', u'B:mapping'
score u'1', u'2'
end u'A:mapping', u'B:mapping'
start u'A:mapping', u'B:mapping'
score u'1', u'2'
end u'A:mapping', u'B:mapping'

With this patch, the same data is correctly displayed as:

Variable Value
start u'A:mapping'
score u'1'
end u'A:mapping'
start u'B:mapping'
score u'2'
end u'B:mapping'

The keys for POST vars with duplicate names were being (correctly) listed
in their orignal order, however *all* values for each of these keys
were (incorrectly) listed for each occurance of the duplicated keys.
(This is particularly confusing, e.g., when looking at,
e.g. `peppercorn`_-encoded data.)

.. _peppercorn: http://peppercorn.readthedocs.org/
@mmerickel
Copy link
Member

This looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants