Use root_path in sse URL #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change toolbar mako file so that sse urls use the passed in root path rather than assuming the toolbar is at /.
|
Nice fix, thanks! |
jvanasco
added a commit
to jvanasco/pyramid_debugtoolbar
that referenced
this pull request
Nov 4, 2014
This was referenced Feb 26, 2017
This was referenced Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an app was mounted at anything other than '/', the SSE functionality of the debug toolbar was failing as it was assuming it could hit /debug_toolbar/sse. This PR adds a change so that the template uses the 'root_path' variable to determine the sse url. This root_path was already being passed in, just not used.