Enhancement: Route-Prefixing re Issue #406 #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#406 route_prefix doesn't allow the prefix pattern to match without a trailing slash Enhances route-prefixing by offering greater configuration flexibility to resolve issue #406 comprehensively. Enabled by ``pyramid.allow_empty_pattern`` for BW compatibility. Relevant toward creating more-explicit configuration behavior and supporting project designs that use the non-slash-appended route-style without ugly workarounds. Supports TIMTOWTDI design defense. Option to ship Pyramid with whatever default is deemed most 'correct' as the web evolves. Affects project that: a.) enable ``pyramid.allow_empty_pattern``, AND; b.) mount an empty pattern under a prefix ('/prefix' + ''), AND; c.) expect a slash-appended route to be created ('/prefix/'). Docs: - Provided further route-prefixing design examples re sub-callables and nested prefixes where common usage might be to prefix a locale string to a module routes (e.g. ``/{_LOCALE_}/users/show``); - Documented enhanced route-prefix behaviour and added advisory note for existing projects that want to enable ``pyramid.allow_empty_pattern``.
…refix has configurative behaviour, and add complementary route-suffix behaviour to give control over the other end of the patterh i.e. control over creation of a slash-appended or non-slash-appended routes
|
Demonstrate approach of passing route_prefixes as lists instead of strings, in order to simplify code and do all route-pattern creation in add_route. Todo: change var names |
…refix_list varname to route_prefix, same for route_suffix, prepend suffixes to avoid later copy-and-reverse
…move list initialisation
…-pattern operations in ``route_pattern class``, and make code that uses ``route_pattern`` class neater. Reformat text-width of doc additions.
|
Finally bring all thinking into a neat |
|
Closed as I have proposed an alternative solution and code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#406
Suggested solution:
route_patternclass (extendinglist) to centralise route joining operations, principally providing a__str__method.route_prefixconfigurative behaviour viaroute_pattern.match_slash_stylebool attribute, where left-most item influences the route-pattern slash-style (slash-appended or non-slash-appended).route_suffixas the logical compliment toroute_prefix, but having no configurative behaviour;route_prefixaffects the route-pattern after the addition of any suffixes. Route-suffixes are added outward with the outer-mostinclude's route-suffix added last.