pserve open_url config setting #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the port from the server section could be brought back but it would be a fallback that depends on finding a "port" variable in the [server:server_name] section of the config.
mmerickel
force-pushed
the
pserve-open-url
branch
from
54bb86c to
85a5c62
Compare
mmerickel
changed the title
mmerickel
force-pushed
the
pserve-open-url
branch
from
85a5c62 to
d28423d
Compare
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Mar 29, 2017
mmerickel
force-pushed
the
pserve-open-url
branch
from
d28423d to
839dbff
Compare
digitalresistor
approved these changes
Mar 29, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current open browser code is really hacky and is going to be difficult to support in plaster. This is a compromise that is slightly more explicit and should work in most situations. Basically it first tries to find an
open_urlsetting in the[pserve]config section. If that fails it looks forportin[server:<server_name>]config section. If it can't find either then it issues a warning.