Make sure PServeCommand kwargs are passed to the hupper worker. #2974
Conversation
mmerickel
force-pushed
the
backport-2962-to-1.8-branch
branch
from
f3d4fff to
108a23f
Compare
mmerickel
force-pushed
the
backport-2962-to-1.8-branch
branch
from
108a23f to
6eceb02
Compare
|
Hi @mmerickel Would you have some bandwith to cut a 1.8.3 release with this fix please? |
|
@Natim Are there any other issues that need fixing first? Cutting releases takes a bit of time and we don't want to have to spin 1.8.4 tomorrow... |
|
If they were I would have filed PR... |
We were just referring to the last release when you opened a new bug report a day after, so it would be appreciated if you tested the unreleased 1.8-branch first to avoid anything obvious showing up immediately again. Plus you will get them fixed sooner without waiting a few weeks for another release. Regardless, please don't take that as an insult, I certainly appreciate the bug reports. I will cut a release this weekend at the latest with the changes. |
|
As far as I know we didn't detect any bug since this one. I will test the branch tomorrow. I am a bit worried that you feel it is hard to do a release, maybe we should change the process to make it easy. In our team we are using zest.releaser and updating the changelog in each PR so it is really easy to cut a release. |
|
@Natim releasing is not hard, it is merely time consuming. See our complete checklist, RELEASING.txt. If |
|
Apparently we actually did :( #2975 |
|
@Natim that's a change of a default... that won't be going into a 1.8 bugfix release unfortunately. |
|
Ok then we are good for 1.8.3 |
Backport of #2962 to 1.8-branch.