add override
option to add_translation_dirs
#2902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debated with myself for a very long time whether to set
override=True
by default or not and in the end I simply cannot come up with a compelling reason to break bw-compat. I took a page out of pyramid_jinja2's book withadd_jinja2_search_path
which also adds new items with lower priority than previously added items. This is consistent with that, as well as previous behaviors.fixes #1474