remove the deprecated IContextURL #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
remove-deprecated-icontexturl
branch
from
3bc1745 to
b1e4b7f
Compare
mmerickel
force-pushed
the
remove-deprecated-icontexturl
branch
from
b1e4b7f to
07a6e64
Compare
mmerickel
force-pushed
the
remove-deprecated-icontexturl
branch
from
07a6e64 to
7ba9075
Compare
|
Updated this with an attempt at using |
|
I am not as familiar with this part of the code base. From just a discerning eye and looking over the logic, it looks good to me. |
digitalresistor
added a commit
that referenced
this pull request
Dec 15, 2016
This was referenced Jan 22, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for the IContextURL interface that was deprecated in 1.3. The only part that was pretty confusing for me was the reimplementation of
pyramid.traversal.virtual_rootwhich seems somewhat different than before. It no longer consults the registeredIResourceURLobject for the given resource and thus the root is not configurable. I really have no idea if this is okay.It'd be really great if @mcdonc could review this considering he originally deprecated this interface and probably understands the purpose of the API much better than I.