add a callback hook to set_default_csrf_options for disabling checks … #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
reviewed
Oct 11, 2016
|
|
||
| def test_changing_set_default_csrf_options(self): | ||
| from pyramid.interfaces import IDefaultCSRFOptions | ||
| config = self._makeOne(autocommit=True) | ||
| def callback(request): return True |
There was a problem hiding this comment.
Why the single-line function here?
There was a problem hiding this comment.
The function is never executed in this test, so it's either that or a pragma or a lambda. A lot of the other tests use this pattern to keep coverage.
There was a problem hiding this comment.
callback = lambda x: True
gives pep8 warnings, since you aren't supposed to assign a lambda to a variable...
|
LGTM. |
mmerickel
added a commit
that referenced
this pull request
Apr 13, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…per-request
fixes #2596