Fix renderers: JSON is not text and has no charset #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalresistor
added a commit
that referenced
this pull request
Jul 17, 2016
If the Response contains no charset we can't use Response.text. We now implicitly encode to UTF-8 after showing a warning.
digitalresistor
force-pushed
the
fix/renderers
branch
from
1fe0b08 to
45f8822
Compare
|
LGTM. We should backport this to 1.6 and 1.7. |
|
I'll get back ports completed later today. |
digitalresistor
added a commit
that referenced
this pull request
Jul 19, 2016
digitalresistor
added a commit
that referenced
this pull request
Jul 19, 2016
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Aug 16, 2016
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Aug 16, 2016
This reverts commit e00f8b0.
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Aug 16, 2016
This reverts commit e00f8b0.
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Aug 17, 2016
This reverts commit e00f8b0.
mmerickel
added a commit
that referenced
this pull request
Aug 17, 2016
revert changes to the renderers from #2706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2691, and means there has to be no new
default_encodingin WebOb and removes the backwards incompatible change that would bring with it.WebOb is still backwards incompatible in that it removed the default charset for
application/json, but setting it in the first place was wrong.