Add some validation for the JSONP callback #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback variable could be used to arbitrarily inject javascript into the response object. This validates that the callback doesn't begin with a number and is standard US ASCII characters, because trying to make sure the JavaScript function name is actually valid would require parsing JavaScript itself...
|
Do note that this isn't a HUGE security vulnerability because to allow this to be abused a user has to be able to insert callback variables into the remote page that happens to be doing a JSONP request to a Pyramid application. If you can already insert data into the page to change the callback variable that is sent to Pyramid, you already have access to the site in the first place, and you really don't need to modify the callback variable. Either way it's a nice to have that we at least sanity check it. |
|
@mcdonc You pulled this into 1.4 and 1.5, but not master, nor 1.6, do you want me to cherry-pick it onto 1.6 too? |
mmerickel
added a commit
that referenced
this pull request
Apr 20, 2015
Add some validation for the JSONP callback
mmerickel
added a commit
that referenced
this pull request
Apr 20, 2015
|
I've applied this to 1.6-branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback variable could be used to arbitrarily inject javascript
into the response object. This validates that the callback doesn't begin
with a number and is standard US ASCII characters, because trying to
make sure the JavaScript function name is actually valid would require
parsing JavaScript itself...