remove the token from the ICacheBuster api #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the QueryStringCacheBuster and PathSegmentCacheBuster public APIs alongside the md5-variants. These should be more cleanly subclassed by people wishing to extend their implementations.
| .. versionadded:: 1.6 | ||
| """ | ||
| def __init__(self): | ||
| PathSegmentCacheBuster.__init__(self) |
There was a problem hiding this comment.
Any reason you're calling these explicitly instead of just doing:
def __init__(self, *args, **kwargs):
super(PathSegmentMd5CacheBuster, self).__init__(*args, **kwargs)Should be less fragile that way as long as you make sure you pull out any kwargs/args that the class whose defining the __init__ adds.
|
Added a comment about the particular implementation, but otherwise this looks good to me. |
|
LGTM |
mmerickel
added a commit
that referenced
this pull request
Feb 17, 2015
remove the token from the ICacheBuster api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the QueryStringCacheBuster and PathSegmentCacheBuster
public APIs alongside the md5-variants. These should be more cleanly
subclassed by people wishing to extend their implementations.
Fixes #1582.