Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent timing attacks when checking CSRF token #1574

Merged
merged 2 commits into from
Feb 10, 2015

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Feb 10, 2015

No description provided.

@mmerickel
Copy link
Member

I think you need to check if the token is None prior to passing it into strings_differ right now.

@dstufft
Copy link
Contributor Author

dstufft commented Feb 10, 2015

Ah right, that's what I get for using the web editor.

@dstufft
Copy link
Contributor Author

dstufft commented Feb 10, 2015

There we go, fixed that.

mmerickel added a commit that referenced this pull request Feb 10, 2015
Prevent timing attacks when checking CSRF token
@mmerickel mmerickel merged commit 6a9d195 into Pylons:master Feb 10, 2015
@mmerickel
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants