Query string arg names starting with equal sign

[timka]

I use %3D (URL encoded equal sign) prefix in argument name for filter parametrization:

GET /users?%3Dphone_number=1234567

Since request_param supports matching specific values with equal sign syntax, this doesn't work when route registered with explicit filter args names in request_param.

[mmerickel]

I feel that this patch is too specific to your use case. It would be more appropriate to use your own predicate instead of pyramid's default predicate for such a thing. See http://docs.pylonsproject.org/projects/pyramid/en/1.5-branch/narr/hooks.html#adding-a-third-party-view-route-or-subscriber-predicate for more info on creating custom predicates.

[mcdonc]

I'm on the fence about it but I think I'm going to agree with @mmerickel because there just isn't a "right" way to fix this given that some textual sentinel separator needs to be used. That said, it's unambiguous that it should not be at the beginning of the string, so it might be reasonable to restrict the patch to startswith.

[timka]

@mmerickel Well, this is what I do to get it working. On the other hand, having arg name starting with '=' is perfectly correct and compatible with current syntax.

@mcdonc I agree regarding the restriction. That was my initial idea actually, but I couldn't resist the temptation to generalize, you know :)

[mcdonc]

I'd accept a patch that did the startswith thing, although an additional test would be nice too.

[timka]

Added some tests for this case based on existing similar tests

[mmerickel]

So this PR states that the arg starts with an equals sign, but it appears as if the patch prevents the arg from having a value. For example, =foo=bar will not be properly split into '=foo' == 'bar'. If you want to update the patch with a fix/test for that, I'll be happy to merge it.

[sontek]

@timka Did you see @mmerickel's request?

[timka]

Sorry for the delay

[mmerickel]

Hey @timka, I'm sorry I didn't mention this earlier. Can you please add another commit with your name in CONTRIBUTORS.txt?

[timka]

No prob