added line numbers to generic log formatter #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, if this doesn't get merged, you can always create your own scaffolds which contain this in the default .ini file :-) |
|
Are there any objections to this getting merged? It seems pretty harmless to me. I'll wait a day or so to see if there's any concerns. |
|
This seems like a harmless change, and as @Geonetix posted it is interesting information that certainly helps with debugging. |
mmerickel
added a commit
that referenced
this pull request
Nov 10, 2014
added line numbers to generic log formatter
mmerickel
added a commit
that referenced
this pull request
Nov 10, 2014
|
Thanks again, I updated development.ini in a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is literally the most interesting "default" information in logs and we change it for every project again and again, in our case, at least. It would be amazing if this could go upstream.