Test failures on 1.5.1

[domenkozar]

======================================================================
FAIL: test_without_content_type (pyramid.tests.test_response.TestFileResponse)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-python3.3-pyramid-1.5.1.drv-2/pyramid-1.5.1/pyramid/tests/test_response.py", line 61, in test_without_content_type
    self.assertEqual(r.content_type, content_type.split(';')[0])
AssertionError: 'text/xml' != 'application/xml'
- text/xml
+ application/xml

[tseaver]

What OS? That test passes for me on Ubuntu 12.04.

[tseaver]

May be a difference in the '/etc/mimetypes' on your system vs. mine::

$ mimetype pyramid/tests/fixtures/minimal.xml
pyramid/tests/fixtures/minimal.xml: application/xml

[domenkozar]

NixOS. Where do I get the mimetype command?

[tseaver]

I don't know from NixOS. On Precise::

$ dpkg-query --search /usr/bin/mimetype 
libfile-mimeinfo-perl: /usr/bin/mimetype

[mmerickel]

FWIW duplicate of #1389.

[mmerickel]

We may just want to patch mimetypes for the purposes of that test to avoid system configuration issues.

[tseaver]

We could change the test to assert that the return value matches the result from ' mimetypes.guess_type(url, strict=False)'.

[lmacken]

This test fails for me on Fedora. mimetype pyramid/tests/fixtures/minimal.xml says application/xml but mimetypes.guess_type returns text/xml.

[mmerickel]

+1 on just checking the return type against mimetypes.guess_type as @tseaver suggested. I don't think we're interested in going any further into requiring a specific mimetype than what the library says.

[domenkozar]

I've submitted a PR #1446