Define URL generator when instantiating Page

[rbu]

Defining the page_url from the template with the $page replacement protocol does not seem like the right place to us. It would be much more convenient, if we could alternatively provide a URL generation function during instantiation.

From an API side, this could be used as:

def page_url_maker(page_number):
     return "http://example.com?page=%s" % page_number 
Page(items, number, page_url_maker=page_url_maker)
...

# template
{{ page.pager() | safe }}

In Pyramid, a simple page maker could be

    def make_page_url(page_number):
        return request.current_route_url(_query=dict(page=page_number))

We are currently doing this in a Page subclass, but getting it upstream would be preferable. I can provide a pull request, but wanted to make sure this has a chance of getting accepted first.

[Signum]

Hi Robert,

yes, I was considering such a URL generation callback. My first priority
was to make paginate independent from Pylons or Pyramid by using as few
external dependencies as possible. For many people it might be
sufficient to just use a page parameter but I fully understand that you
would like to have more control.

So if you could provide a proper patch I'll merge it. Thanks.

Kindly
…Christoph

[rbu]

I'm all in favor of not sticking to one framework and keeping it free from the magic you removed in 99b590e.

Pushed a patch to my fork. Thanks for offering to merge!

[rbu]

Relating to my commit message. Until Pyramid solves Pylons/pyramid#1040, you'll have to write this as

def url_maker(page_number):
    query = request.GET
    query['page'] = str(page_number)
    return request.current_route_url(_query=query)

[rbu]

We're currently shipping a fork of paginate in our product including this commit. Generally, I'd prefer not to derive from upstream too much. Can you give some general feedback on the patch's acceptability? What are the chances of seeing a merge / release?

[Signum]

Sorry, I missed your commit. Thanks for the patch - I have merged it. Please next time consider sending a pull request.