Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role icon argument not setting unicode_emoji to None #876

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Fix role icon argument not setting unicode_emoji to None #876

merged 3 commits into from
Jan 28, 2022

Conversation

argo0n
Copy link
Contributor

@argo0n argo0n commented Jan 28, 2022

Warning: We have a feature freeze till release

That means we won't accept new features for now. Only bug fixes.

Summary

This pull request is for the issue #874. All it does is to pass unicode_emoji as None so that when icon is passed, the unicode_emoji will not conflict with the new icon set.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@argo0n argo0n changed the title Fix role icon not setting unicode_emoji to None Fix role icon argument not setting unicode_emoji to None Jan 28, 2022
@Lulalaby Lulalaby added this to the v2.1 milestone Jan 28, 2022
@Lulalaby Lulalaby modified the milestones: v2.1, v2.0 Jan 28, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) January 28, 2022 14:58
@Lulalaby Lulalaby requested a review from Middledot January 28, 2022 14:58
@VincentRPS VincentRPS added bug Something isn't working Merge with squash priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Jan 28, 2022
@plun1331
Copy link
Member

This sounds more like a Discord problem than a library bug

@Lulalaby
Copy link
Member

This sounds more like a Discord problem than a library bug

No it is an fault in our lib

@Lulalaby Lulalaby merged commit a15aaf9 into Pycord-Development:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants