Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: client: Ignore RuntimeError when calling add_signal_handler() #673

Merged
merged 1 commit into from
Jan 7, 2022
Merged

discord: client: Ignore RuntimeError when calling add_signal_handler() #673

merged 1 commit into from
Jan 7, 2022

Conversation

SebaUbuntu
Copy link
Contributor

Summary

  • When Client.run() is called in a new thread (using threading.Thread), add_signal_handler will raise the following exception:
  • RuntimeError: set_wakeup_fd only works in main thread of the main interpreter
  • We can ignore this as well

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@SebaUbuntu
discord: client: Ignore RuntimeError when calling add_signal_handler()
6800b72 
* When Client.run() is called in a new thread (using threading.Thread), add_signal_handler will raise the following exception:
* RuntimeError: set_wakeup_fd only works in main thread of the main interpreter
* We can ignore this as well

Change-Id: Id21beaff59e1450186c4410e1ead41c0f738e01e
Signed-off-by: Sebastiano Barezzi <[email protected]>
@Lulalaby Lulalaby added this to the v2.1 milestone Jan 7, 2022
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority Merge with squash labels Jan 7, 2022
@Middledot Middledot enabled auto-merge January 7, 2022 17:51
@Middledot Middledot disabled auto-merge January 7, 2022 17:51
@Middledot Middledot enabled auto-merge (squash) January 7, 2022 17:51
@Middledot Middledot merged commit 6084448 into Pycord-Development:master Jan 7, 2022
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@SebaUbuntu @VincentRPS
discord: client: Ignore RuntimeError when calling add_signal_handler() (
defeef9 
Pycord-Development#673)

* When Client.run() is called in a new thread (using threading.Thread), add_signal_handler will raise the following exception:
* RuntimeError: set_wakeup_fd only works in main thread of the main interpreter
* We can ignore this as well

Change-Id: Id21beaff59e1450186c4410e1ead41c0f738e01e
Signed-off-by: Sebastiano Barezzi <[email protected]>
@VincentRPS VincentRPS modified the milestones: v2.1, v2.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Middledot Middledot Middledot approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SebaUbuntu @Lulalaby @Middledot @VincentRPS