Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to autocomplete's values (OptionChoices) #580

Merged
merged 6 commits into from
Dec 29, 2021
Merged

Fix to autocomplete's values (OptionChoices) #580

merged 6 commits into from
Dec 29, 2021

Conversation

Vioshim
Copy link
Contributor

@Vioshim Vioshim commented Dec 18, 2021

Summary

Currently the autocomplete has the issue of trying to convert tuples into string, and not being able to work with OptionChoices, this commit fixes all those issues and allows it to work with tuples, OptionChoices and such.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

plun1331
plun1331 reviewed Dec 18, 2021
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't see the point in supporting tuples, just pass an OptionChoice yourself.

@Lulalaby Lulalaby enabled auto-merge December 18, 2021 07:29
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Dec 18, 2021
@Lulalaby Lulalaby added this to the v2.0 milestone Dec 18, 2021
auto-merge was automatically disabled December 18, 2021 07:34

Head branch was pushed to by a user without write access

VincentRPS
VincentRPS previously approved these changes Dec 18, 2021
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge December 19, 2021 00:34
Lulalaby
Lulalaby previously approved these changes Dec 19, 2021
View reviewed changes
@Lulalaby Lulalaby requested a review from Dorukyum December 19, 2021 00:35
@Vioshim
removing tuple usage
e6b49ae 
removing tuple usage
auto-merge was automatically disabled December 19, 2021 07:38

Head branch was pushed to by a user without write access

@Vioshim Vioshim dismissed stale reviews from Lulalaby and VincentRPS via e6b49ae December 19, 2021 07:38
@Vioshim
removing tuple usage
b1b9948 
removing tuple usage
@Lulalaby Lulalaby changed the title Fix to autocomplete's values (tuples and OptionChoices) Fix to autocomplete's values (OptionChoices) Dec 19, 2021
Dorukyum
Dorukyum reviewed Dec 28, 2021
View reviewed changes
discord/utils.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby enabled auto-merge December 29, 2021 08:26
@Lulalaby Lulalaby disabled auto-merge December 29, 2021 08:26
@Lulalaby Lulalaby enabled auto-merge (squash) December 29, 2021 08:27
@Lulalaby Lulalaby disabled auto-merge December 29, 2021 08:27
@Lulalaby Lulalaby enabled auto-merge December 29, 2021 08:27
@Lulalaby Lulalaby merged commit 8e5ef7e into Pycord-Development:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@VincentRPS VincentRPS VincentRPS left review comments

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Vioshim @Lulalaby @plun1331 @Dorukyum @VincentRPS @BobDotCom