Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add accurate type hints to HistoryIterator #2340

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: add accurate type hints to HistoryIterator #2340

merged 2 commits into from
Jan 30, 2024

Conversation

honzajavorek
Copy link
Contributor

Summary

Reading the code, it was a bit confusing to see -> list[Message] while it should be -> list[MessagePayload] in that context.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@honzajavorek
add types
520d003 
Signed-off-by: Honza Javorek <[email protected]>
@honzajavorek honzajavorek requested a review from a team as a code owner January 30, 2024 10:09
@pullapprove4 pullapprove4 bot requested a review from FrostByte266 January 30, 2024 10:10
@honzajavorek honzajavorek changed the title Add types to HistoryIterator internals fix: Add types to HistoryIterator internals Jan 30, 2024
@Dorukyum Dorukyum changed the title fix: Add types to HistoryIterator internals fix: add accurate type hints to HistoryIterator Jan 30, 2024
@Dorukyum Dorukyum enabled auto-merge (squash) January 30, 2024 12:03
@Dorukyum Dorukyum requested a review from Lulalaby January 30, 2024 12:03
@Dorukyum Dorukyum merged commit 73ef733 into Pycord-Development:master Jan 30, 2024
33 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@honzajavorek @pre-commit-ci @OmLanke
fix: add accurate type hints to HistoryIterator (Pycord-Development…
3fbf6df 
…#2340)

* add types

Signed-off-by: Honza Javorek <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: Honza Javorek <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzajavorek @Lulalaby @Dorukyum