Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add setters to some Embed properties #2199

Closed
wants to merge 4 commits into from
Closed

fix: Add setters to some Embed properties #2199

wants to merge 4 commits into from

Conversation

FloncDev
Copy link

@FloncDev FloncDev commented Aug 6, 2023

Summary

Adds setter to Embed.footer, Embed.image, Embed.thumbnail and Embed.author
Fixes #2197

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby
Copy link
Member

Lulalaby commented Aug 6, 2023

Thanks for the pull request, tho it's a dup of #2198

@Lulalaby Lulalaby closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed class missing property setters
2 participants