Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): Bridge options & bool converter breaking sometimes #1999

Merged
merged 6 commits into from
Apr 17, 2023
Merged

fix(ext.bridge): Bridge options & bool converter breaking sometimes #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc6936b
fix(ext.bridge): bool opt breaks sometimes
Middledot Apr 3, 2023
7f51422
chore(changelog): changelog
Middledot Apr 3, 2023
e536a8f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 3, 2023
191d4e8
Merge branch 'master' into fix-1972-bool-opt-broke
Middledot Apr 3, 2023
ab308c6
Merge branch 'master' into fix-1972-bool-opt-broke
Middledot Apr 6, 2023
38c67f2
Merge branch 'master' into fix-1972-bool-opt-broke
BobDotCom Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#1994](https://github.com/Pycord-Development/pycord/pull/1994))
- Fixed scheduled events breaking when changing the location from external to a channel.
([#1998](https://github.com/Pycord-Development/pycord/pull/1998))
- Fixed boolean converter breaking for bridge commands. Fix bridge command Options not
working. ([#1999](https://github.com/Pycord-Development/pycord/pull/1999))
- Fixed `TypeError` being raised when passing `name` argument to bridge groups.
([#2000](https://github.com/Pycord-Development/pycord/pull/2000))

Expand Down
8 changes: 7 additions & 1 deletion discord/ext/bridge/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,15 @@ async def convert(self, ctx: Context, arg: str):
return attach


class BooleanConverter(Converter):
async def convert(self, ctx, arg: bool):
return _convert_to_bool(str(arg))


BRIDGE_CONVERTER_MAPPING = {
SlashCommandOptionType.string: str,
SlashCommandOptionType.integer: int,
SlashCommandOptionType.boolean: lambda val: _convert_to_bool(str(val)),
SlashCommandOptionType.boolean: BooleanConverter,
SlashCommandOptionType.user: UserConverter,
SlashCommandOptionType.channel: GuildChannelConverter,
SlashCommandOptionType.role: RoleConverter,
Expand Down Expand Up @@ -579,3 +584,4 @@ async def convert(self, ctx, argument: str) -> Any:


discord.commands.options.Option = BridgeOption
discord.Option = BridgeOption