fix: ip discovery changes (74 byte udp packets) #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Lulalaby
commented
Mar 1, 2023
Signed-off-by: Lala Sabathil <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1955 +/- ##
=======================================
Coverage 33.32% 33.32%
=======================================
Files 97 97
Lines 18901 18901
=======================================
Hits 6298 6298
Misses 12603 12603
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Lulalaby
requested review from
BobDotCom,
JustaSqu1d,
Dorukyum,
NeloBlivion and
VincentRPS
Lulalaby
added
bug
BobDotCom
reviewed
Mar 2, 2023
Co-authored-by: BobDotCom <[email protected]> Signed-off-by: Lala Sabathil <[email protected]>
JustaSqu1d
approved these changes
Mar 2, 2023
NeloBlivion
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
LGTM and tested fine, though this technically isn't a new change; it's been 74 bytes since December 2019 while 70 bytes has been deprecated since then, and now they're finally removing it completely.
This could be made clearer in the changelog, but this difference isn't particularly important to the user.
BobDotCom
added a commit
that referenced
this pull request
Mar 20, 2023
* fix: ip discovery changes (74 byte udp packets) * chore: Pr will be 1955 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CHANGELOG.md Signed-off-by: Lala Sabathil <[email protected]> * Update CHANGELOG.md Co-authored-by: BobDotCom <[email protected]> Signed-off-by: Lala Sabathil <[email protected]> --------- Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: BobDotCom <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1954