Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AttributeErrors from event handler move #1946

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

NeloBlivion
Copy link
Member

Summary

Someone didn't press ctrl+f Renames extra_events to _event_handlers which caused issues during command errors and cog unloading.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner February 26, 2023 14:13
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #1946 (973de8b) into master (34a23eb) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 973de8b differs from pull request most recent head 6eea11e. Consider uploading reports for the commit 6eea11e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   33.36%   33.36%           
=======================================
  Files          97       97           
  Lines       18851    18851           
=======================================
  Hits         6289     6289           
  Misses      12562    12562           
Flag Coverage Δ
macos-latest-3.10 33.34% <0.00%> (ø)
macos-latest-3.11 33.34% <0.00%> (ø)
macos-latest-3.8 33.35% <0.00%> (ø)
macos-latest-3.9 33.35% <0.00%> (ø)
ubuntu-latest-3.10 33.34% <0.00%> (ø)
ubuntu-latest-3.11 33.34% <0.00%> (ø)
ubuntu-latest-3.8 33.35% <0.00%> (ø)
ubuntu-latest-3.9 33.35% <0.00%> (ø)
windows-latest-3.10 33.34% <0.00%> (ø)
windows-latest-3.11 33.34% <0.00%> (ø)
windows-latest-3.8 33.35% <0.00%> (ø)
windows-latest-3.9 33.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/cog.py 34.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a23eb...6eea11e. Read the comment docs.

@Lulalaby Lulalaby added bug Something isn't working changelog needed labels Feb 26, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Feb 26, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) February 26, 2023 14:52
@Lulalaby Lulalaby requested a review from ChickenDevs February 26, 2023 14:52
@Lulalaby
Copy link
Member

I hate that update branch is enforced -.-

@Lulalaby Lulalaby requested a review from plun1331 February 26, 2023 15:13
@Lulalaby Lulalaby added the priority: high High Priority label Feb 26, 2023
@Lulalaby Lulalaby merged commit 2e09718 into Pycord-Development:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants