-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Client.on_error() improvement with new parameter #1945
Conversation
Edited _run_event to pass the exception to on_error. Signed-off-by: Guard Boi <[email protected]>
Signed-off-by: Guard Boi <[email protected]>
Signed-off-by: Guard Boi <[email protected]>
Signed-off-by: Guard Boi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Guard Boi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
=======================================
Coverage 33.13% 33.13%
=======================================
Files 97 97
Lines 19136 19136
=======================================
Hits 6340 6340
Misses 12796 12796
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
This is a breaking change |
didnt give me an error in testing, reverting Signed-off-by: Guard Boi <[email protected]>
Co-authored-by: Om <[email protected]> Signed-off-by: Guard Boi <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
This pull request is in the In review step of the Default workflow. The following review teams are pending:
|
Changelog entry is in the wrong section |
Fix it then :) |
|
Edited _run_event to pass the exception to on_error.
Summary
in
client.py
, line 381 has includedas exc
in order to pass an exception intoClient.on_error
. This has also been changed in line 438 to 448, changing how the error is printed as well. This makes it easier to useon_error
with this small change.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.