Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify required argument types for variadic functions #1850

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

mattabullock
Copy link
Contributor

@mattabullock mattabullock commented Jan 2, 2023

Summary

On arm64 macOS, variadic functions have special calling rules. In pycord the correct argument types have to be specified so ctypes can pass them correctly.

Apple docs: https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms#Update-Code-that-Passes-Arguments-to-Variadic-Functions

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@mattabullock mattabullock requested a review from a team as a code owner January 2, 2023 19:03
@mattabullock mattabullock changed the title Specify required argument types for variadic functions fix: Specify required argument types for variadic functions Jan 2, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) January 3, 2023 01:01
@Lulalaby Lulalaby added priority: low Low Priority status: awaiting review Awaiting review from a maintainer bug Something isn't working labels Jan 3, 2023
@Lulalaby Lulalaby added this to the v2.4 milestone Jan 3, 2023
@Lulalaby Lulalaby merged commit 8de86f4 into Pycord-Development:master Jan 3, 2023
@Lulalaby Lulalaby removed the status: awaiting review Awaiting review from a maintainer label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: low Low Priority
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants