-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): warning on overriding on_connect #1689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we really want to do something @bot.event
async def on_connect():
if bot.auto_sync_commands:
await bot.sync_commands()
print(f"{bot.user.name} connected.") I think it's worth including a note about this possibility in the warning. Right now there is no example and it's only being mentioned for
|
Lulalaby
added
documentation
Improvements or additions to documentation
priority: low
Low Priority
labels
Oct 11, 2022
Middledot
approved these changes
Oct 15, 2022
Lulalaby
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It adds a warning on the documentation about overriding
on_connect
. Also fixes a few related broken references.Preview: https://pycord-squid-branch.readthedocs.io/en/latest/api.html#discord.Bot.auto_sync_commands
https://pycord-squid-branch.readthedocs.io/en/latest/api.html#discord.on_connect
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.