Reworked get_application_command behaviour
#1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Lulalaby
previously approved these changes
Oct 8, 2022
Dorukyum
reviewed
Oct 9, 2022
Lulalaby
added
priority: medium
|
ping pong |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
- Coverage 33.25% 33.23% -0.02%
==========================================
Files 95 95
Lines 18412 18423 +11
==========================================
Hits 6123 6123
- Misses 12289 12300 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auto-merge was automatically disabled
October 16, 2022 19:16
Head branch was pushed to by a user without write access
BobDotCom
approved these changes
Oct 17, 2022
Lulalaby
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
typenow defaults toApplicationCommand, allowing users to get any command type by default instead of justSlashCommand. While changing defaults without warning could be considered breaking, all command names must already be unique and as such changing the default type would have no effect unless, for some reason, the user was intentionally gettingNonewhile using an existing command name.The main addition here is support for qualified command names to easily get subgroups/subcommands, similar to how
get_commandworks onext.commands.Bot. This search occurs if they input a somewhat valid qualified name, only validating if it's all lowercase and exactly two or three words (e.g.group subcommandorgroup subgroup subcommandwould both be valid.)Closes #1625
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.