Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threads made from messages breaking #1551

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Fix threads made from messages breaking #1551

merged 1 commit into from
Aug 7, 2022

Conversation

Middledot
Copy link
Member

@Middledot Middledot commented Aug 7, 2022 •
edited
Loading

Summary

Messages sent when creating a thread of another message have the message_reference set to the original message, and so breaking everything. (#1491 (comment) has more information)

Fix #1491

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added the bug Something isn't working label Aug 7, 2022
@Middledot Middledot mentioned this pull request Aug 7, 2022
Closed
3 tasks
Dorukyum
Dorukyum approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ChickenDevs ChickenDevs merged commit 8eb120d into Pycord-Development:master Aug 7, 2022
@Middledot Middledot deleted the fix-1491 branch August 7, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'get_thread'
3 participants
@Middledot @Dorukyum @ChickenDevs