-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge restructure into slash #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobDotCom
force-pushed
the
restructure
branch
from
September 8, 2021 20:16
fe4f928
to
530a141
Compare
merge slash into restructure
Implement custom converter types
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure
This restructure is extensive and will involve moving many methods, attributes, and such from
ext.commands
up to the main namespace for use withdiscord.Bot
. A generalized list of changes will be listed here but may be incomplete. Most commits will need typehinting and documentation (see below).Finalizing each commit
After each main commit is finished, it will be added to a checklist here. After all main commits are finished, they will need to be finalized. To make a finalization commit, you should
TYPE: ...
in comments. These variables (or parameters) should be typehinted to the provided string. You may need to look at the old code (inext.commands
) and see what the variable references are.ext.commands
, look forOVERRIDE 1234: ...
in comments. These should all be removed. They may include parameters, lines, or ranges (inclusive) of lines to delete. Do this after typehinting. Most commits won't have lines to remove or may already have them removedCommits
restructure BotBase.__init__
Edit discord.Bot docstring
Fix documentation for 13020e6630d1f105f14bdd57418e8fb536b0a015