Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge restructure into slash #138

Merged
merged 29 commits into from
Oct 19, 2021
Merged

Merge restructure into slash #138

merged 29 commits into from
Oct 19, 2021

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Sep 8, 2021

Restructure

This restructure is extensive and will involve moving many methods, attributes, and such from ext.commands up to the main namespace for use with discord.Bot. A generalized list of changes will be listed here but may be incomplete. Most commits will need typehinting and documentation (see below).

Finalizing each commit

After each main commit is finished, it will be added to a checklist here. After all main commits are finished, they will need to be finalized. To make a finalization commit, you should

  1. Find a commit hash in this message
  2. View the commit diff
  3. In added lines, look for TYPE: ... in comments. These variables (or parameters) should be typehinted to the provided string. You may need to look at the old code (in ext.commands) and see what the variable references are.
  4. In the added lines from ext.commands, look for OVERRIDE 1234: ... in comments. These should all be removed. They may include parameters, lines, or ranges (inclusive) of lines to delete. Do this after typehinting. Most commits won't have lines to remove or may already have them removed
  5. Update documentation in both the new and old code
  6. Push to the restructure branch
  7. Check off the commit hash in this message

Commits

  • 13020e6 restructure BotBase.__init__
  • fe4f928 / 530a141 Edit discord.Bot docstring
  • 1dcdaac Fix documentation for 13020e6630d1f105f14bdd57418e8fb536b0a015

@BobDotCom BobDotCom changed the base branch from master to slash September 8, 2021 19:02
@BobDotCom BobDotCom merged commit 6ac921b into feature/slash Oct 19, 2021
@Lulalaby Lulalaby deleted the restructure branch November 3, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress Work in Progess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants