[ext.pages] General fixes and enhancements #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edit the message (used by default), otherwise fall back to message attr edit path adds `custom_view` parameter to `Page` object, which overrides the custom view for the paginator when that page is being shown to better accommodate the above item, a new method `update_custom_view` has been added which will change the `custom_view` of a paginator when called. various other docstring fixes and cleanup
krittick
added
bug
|
Added |
|
Moving to draft status while I work on polishing a couple of the newer items added. |
…action()` add `Paginator.trigger_on_display` (and corresponding `PageGroup`) parameter, which will automatically fire the callback for a `Page` whenever that page is displayed.
…page_count` as -1
7 tasks
|
This is ready for review (again). Slight breaking change introduced by the removal of a return value for |
|
LGTM for me. Not approving tho |
Dorukyum
approved these changes
Apr 6, 2022
Lulalaby
approved these changes
Apr 6, 2022
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the following changes:
Paginator.update_custom_view()- New method used to easily change the custom view shown with the paginator without needing to usePaginator.update()to do so.Page.custom_view- New parameter, represents a custom view assigned to aPageobject, which will be displayed when that page is being displayed. Overrides any definedPaginator.custom_viewwhile the page is being displayed.Paginator.goto_page()now accepts a keyword argumentinteraction. If provided, the message associated to the paginator will be edited via that interaction's response path. If not, thediscord.Messageobject assigned toPaginator.messagewill be used to edit the message instead.PaginatorButtonnow passes itsinteractionautomatically to itsPaginator.goto_page()call by default.Page.callback()method, which can be used to assign a callback to a specific page.Paginator.page_action()method which triggers the callback of the currently displayed page, if one is defined.Paginator.trigger_on_displayparameter which makesgoto_pageautomatically callPaginator.page_action()whenever aPagewith a defined callback is displayed.Checklist
type: ignorecomments were used, a comment is also left explaining why