Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands.FlagConverter 'MissingField' bug #1805

Closed
3 tasks done
Nzii3 opened this issue Nov 29, 2022 · 1 comment · Fixed by #1806
Closed
3 tasks done

commands.FlagConverter 'MissingField' bug #1805

Nzii3 opened this issue Nov 29, 2022 · 1 comment · Fixed by #1806
Labels
bug Something isn't working priority: medium Medium Priority
Milestone
v2.5

Comments

@Nzii3
Copy link
Contributor

Nzii3 commented Nov 29, 2022 •
edited
Loading

Summary

Found a bug with commands.FlagConverter having weird behavior when subclass FlagConverter

Reproduction Steps

Subclass commands.FlagConverter, add a flag with commands.flag().

Minimal Reproducible Code

class Flags(commands.FlagConverter, prefix="?", delimiter=" "):
  reason: commands.flag(aliases=['r'])

Expected Results

The expected and ideal situation is for the code to not raise errors

Actual Results

Errors were raised, such as unexpected arguments (such as the aliases, required or name arguments) and arguments being passed as were classed when were passed as strings or lists.

E7129CB0-6C58-4171-8FA2-53AC8E6D5AA8
23C6F849-46F0-460A-9360-D2CED8BAEFCB
97285D91-395B-4C9A-B4AA-0D722DBFC904

Intents

all

System Information

Library version: latest (2.3.0)

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my token from display, if visible.

Additional Context

Discussed in the library discussion channel multiple times: https://discord.com/channels/881207955029110855/881735314987708456/1038933096013238302
@Nzii3 Nzii3 added the unconfirmed bug A bug report that needs triaging label Nov 29, 2022
Nzii3 added a commit to Nzii3/pycord-ext-pages-test that referenced this issue Nov 29, 2022
@Nzii3
Fix #Pycord-Development#1805
16fede3
@Nzii3 Nzii3 mentioned this issue Nov 29, 2022
Merged
8 tasks
@Nzii3
Copy link
Contributor Author

Nzii3 commented Nov 29, 2022 •
edited
Loading

Pull request created with fix: #1806

@JustaSqu1d JustaSqu1d added bug Something isn't working and removed unconfirmed bug A bug report that needs triaging labels Jan 17, 2023
@Lulalaby Lulalaby added the priority: medium Medium Priority label Feb 9, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Feb 10, 2023
Lulalaby added a commit that referenced this issue Jun 9, 2023
@Nzii3 @Lulalaby @VincentRPS
fix: #1805 (#1806)
a5c2b52 
Fix ##1805

Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: VincentRPS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

fix: #1805 Nzii3/pycord-ext-pages-test
3 participants
@Lulalaby @JustaSqu1d @Nzii3