-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload dev wheels to Anaconda.org + revamp wheels publishing workflow #714
Upload dev wheels to Anaconda.org + revamp wheels publishing workflow #714
Conversation
@rgommers, this is ready for your review whenever you have the time for it. I thought that the changes weren't much! |
With these changes, the PyPI job will run on:
and the Anaconda PyPI index job will run on:
Should we allow the PyPI job to be triggered manually as well? |
Yes, that would be useful to do. |
I guess we should add another input to the |
You are right. Actually, on second thought, this is a little dangerous. It should be a little hard to deploy to PyPI. Let's drop that last change. We do like 1-2 releases a year, so in case there's a problem with building from the tag, let's just make sure a maintainer fixes the problem and then moves the tag to do a release. |
Thanks for the clarification! Yes, PyPI is permanent, so we do not want to trigger a broken release (even if the input is |
I tried this on my fork, and the uploading is broken: https://github.com/rgommers/pywt/actions/runs/8252417966. The problem is the On other projects I see that there is one wheel per zip file with the Python interpreter included in the upload name, e.g.: https://github.com/numpy/numpy/actions/runs/8238976297. I'm not sure if that is the optimal solution. Could you investigate, and then test from the |
Yes, it used to be more lenient with I had not used the I have pushed 90ec5e4 which should fix this, here's a workflow run I have triggered just now – let's see if it passes: https://github.com/agriyakhetarpal/pywt/actions/runs/8252934295 |
Looks like it doesn't like the |
Yes, https://github.com/agriyakhetarpal/pywt/actions/runs/8253018855 works and all wheel builds plus their uploads are passing. |
Now that both Edit: based on our Slack conversation, I shall do this and MUSL wheels in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks good now, so let's give it a go!
I noticed that the Linux aarch64 jobs were taking forever; gh-716 should take care of that. I'll merge that first, so that the wheel builds triggered on merging this PR will be much faster.
The upload to anaconda.org didn't actually work: https://github.com/PyWavelets/pywt/actions/runs/8253753639/job/22576823450. Could you have a look at that? |
Ah never mind, you're already on it! |
Description
This PR introduces the following changes:
deploy_anaconda
job where the wheels can be uploaded to https://anaconda.org/scientific-python-nightly-wheels/PyWavelets/ using thescientific-python/upload-nightly-action
GitHub Actionworkflow_dispatch
trigger to push the nightly wheels, and a CRON schedule that matches the one in Upload nightly wheels for PyWavelets to the Scientific Python Nightly Wheels index on Anaconda #710cibuildwheel
installation with its upstream GitHub Action, in order to get updates from Dependabot (see Keep GitHub Actions up to date with GitHub's Dependabot #708)checkout
actions and bumps the major version fordownload-artifact
andupload-artifact
Footnotes
This PR is related to the changes requested on #712.