-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename reset_on_epoch
to reset_on_run
#9658
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #9658 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15306 15327 +21
=======================================
- Hits 14199 13600 -599
- Misses 1107 1727 +620 |
What does this PR do?
And use the shortcuts where available
The
on_epoch
suffix doesn't apply to all progress objects.Does your PR introduce any breaking changes? If yes, please list them.
The method has been renamed
Before submitting
PR review