Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reset_on_epoch to reset_on_run #9658

Merged
merged 13 commits into from
Sep 25, 2021
Merged

Rename reset_on_epoch to reset_on_run #9658

merged 13 commits into from
Sep 25, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 23, 2021

What does this PR do?

And use the shortcuts where available

The on_epoch suffix doesn't apply to all progress objects.

Does your PR introduce any breaking changes? If yes, please list them.

The method has been renamed

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 23, 2021
@carmocca carmocca self-assigned this Sep 23, 2021
@carmocca carmocca added progress tracking (internal) Related to the progress tracking dataclasses and removed fault tolerance labels Sep 23, 2021
Base automatically changed from feat/save-last-batch to master September 23, 2021 12:54
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) September 23, 2021 13:20
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9658 (056e84b) into master (41e3be1) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 056e84b differs from pull request most recent head 19cdc01. Consider uploading reports for the commit 19cdc01 to get more accurate results

@@           Coverage Diff           @@
##           master   #9658    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15306   15327    +21     
=======================================
- Hits        14199   13600   -599     
- Misses       1107    1727   +620     

@mergify mergify bot added the ready PRs ready to be merged label Sep 23, 2021
@Borda Borda disabled auto-merge September 24, 2021 13:49
@carmocca carmocca merged commit d02fc2b into master Sep 25, 2021
@carmocca carmocca deleted the refactor/reset-on-run branch September 25, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants