-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduled removal of Trainer.running_sanity_check
#9209
Merged
carmocca
merged 3 commits into
Lightning-AI:master
from
Tshimanga:removal/1.5-running-sanity-check
Aug 30, 2021
Merged
scheduled removal of Trainer.running_sanity_check
#9209
carmocca
merged 3 commits into
Lightning-AI:master
from
Tshimanga:removal/1.5-running-sanity-check
Aug 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tshimanga
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 30, 2021 21:32
Tshimanga
commented
Aug 30, 2021
Tshimanga
changed the title
scheduled removal of deprecated property
scheduled removal of Aug 30, 2021
Trainer.running_sanity_check
awaelchli
approved these changes
Aug 30, 2021
awaelchli
added
feature
Is an improvement or enhancement
refactor
design
Includes a design discussion
labels
Aug 30, 2021
awaelchli
reviewed
Aug 30, 2021
@Tshimanga thanks for helping out here! |
carmocca
approved these changes
Aug 30, 2021
Borda
approved these changes
Aug 30, 2021
ananthsub
approved these changes
Aug 30, 2021
Merged
27 tasks
Hi there, |
@radlera This was renamed to |
@kaushikb11 makes some updates here as well: ray-project/ray#20562 |
2 tasks
ndrwnaguib
added a commit
to ndrwnaguib/ray
that referenced
this pull request
Jan 24, 2022
…ing` `running_sanity_check` was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of `sanity_checking`
Merged
6 tasks
amogkam
pushed a commit
to ray-project/ray
that referenced
this pull request
Jan 25, 2022
…cking` (#21831) `running_sanity_check` was deprecated and removed in Lightning-AI/pytorch-lightning#9209 in favor of `sanity_checking`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes deprecated property
Trainer.running_sanity_checking
as scheduled for 1.5Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃