-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GradInformation module, including from LightningModule hierarchy #8831
Merged
ananthsub
merged 2 commits into
Lightning-AI:master
from
ananthsub:feat/remove-grad-information
Aug 19, 2021
Merged
Remove GradInformation module, including from LightningModule hierarchy #8831
ananthsub
merged 2 commits into
Lightning-AI:master
from
ananthsub:feat/remove-grad-information
Aug 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 10, 2021 08:55
Codecov Report
@@ Coverage Diff @@
## master #8831 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 176 175 -1
Lines 14412 14402 -10
=======================================
- Hits 13353 12762 -591
- Misses 1059 1640 +581 |
carmocca
approved these changes
Aug 10, 2021
awaelchli
approved these changes
Aug 10, 2021
yifuwang
approved these changes
Aug 10, 2021
tchaton
approved these changes
Aug 11, 2021
Borda
approved these changes
Aug 12, 2021
ananthsub
force-pushed
the
feat/remove-grad-information
branch
from
August 17, 2021 00:49
f0224f8
to
526a033
Compare
ananthsub
force-pushed
the
feat/remove-grad-information
branch
from
August 17, 2021 15:56
526a033
to
942893c
Compare
justusschock
approved these changes
Aug 18, 2021
This module was deprecated in v1.3 and is slated for removal in v1.5. There's a dedicated utilities file which can be used for this instead.
ananthsub
force-pushed
the
feat/remove-grad-information
branch
from
August 19, 2021 03:16
942893c
to
a5b93a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This module was deprecated in v1.3 and is slated for removal in v1.5. There's a dedicated utilities file which can be used for this instead. This simplifies the lightning module class dependencies
Does your PR introduce any breaking changes? If yes, please list them.
This removes the
GradInformation
module which was previously deprecated in v1.3Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃