Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GradInformation module, including from LightningModule hierarchy #8831

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Aug 10, 2021

What does this PR do?

This module was deprecated in v1.3 and is slated for removal in v1.5. There's a dedicated utilities file which can be used for this instead. This simplifies the lightning module class dependencies

Does your PR introduce any breaking changes? If yes, please list them.

This removes the GradInformation module which was previously deprecated in v1.3

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #8831 (79f8646) into master (6de66eb) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8831    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         176     175     -1     
  Lines       14412   14402    -10     
=======================================
- Hits        13353   12762   -591     
- Misses       1059    1640   +581     

@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2021
@ananthsub ananthsub enabled auto-merge (squash) August 11, 2021 00:45
This module was deprecated in v1.3 and is slated for removal in v1.5. There's a dedicated utilities file which can be used for this instead.
@ananthsub ananthsub merged commit f87b2ef into Lightning-AI:master Aug 19, 2021
@ananthsub ananthsub deleted the feat/remove-grad-information branch August 19, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants