Skip to content

Commit

Permalink
Remove GradInformation from LightningModule hierarchy
Browse files Browse the repository at this point in the history
This module was deprecated in v1.3 and is slated for removal in v1.5. There's a dedicated utilities file which can be used for this instead.
  • Loading branch information
ananthsub committed Aug 17, 2021
1 parent 938a191 commit 526a033
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 44 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- `Trainer.request_dataloader` now takes a `RunningStage` enum instance ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))


### Deprecated

- Deprecated `LightningModule.summarize()` in favor of `pytorch_lightning.utilities.model_summary.summarize()`
Expand Down Expand Up @@ -140,6 +141,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed reset dataloader hooks to Training Plugins and Accelerators ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))


- Removed deprecated `GradInformation` module in favor of `pytorch_lightning.utilities.grads` ([]())


### Fixed

Expand Down
36 changes: 0 additions & 36 deletions pytorch_lightning/core/grads.py

This file was deleted.

2 changes: 0 additions & 2 deletions pytorch_lightning/core/lightning.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from torch.optim.optimizer import Optimizer
from torchmetrics import Metric

from pytorch_lightning.core.grads import GradInformation
from pytorch_lightning.core.hooks import CheckpointHooks, DataHooks, ModelHooks
from pytorch_lightning.core.mixins import DeviceDtypeModuleMixin, HyperparametersMixin
from pytorch_lightning.core.optimizer import LightningOptimizer
Expand All @@ -57,7 +56,6 @@ class LightningModule(
ABC,
DeviceDtypeModuleMixin,
HyperparametersMixin,
GradInformation,
ModelIO,
ModelHooks,
DataHooks,
Expand Down
6 changes: 0 additions & 6 deletions tests/deprecated_api/test_remove_1-5.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,6 @@ def bar(self):
pass


def test_v1_5_0_lighting_module_grad_norm(tmpdir):
model = BoringModel()
with pytest.deprecated_call(match="is deprecated in v1.3 and will be removed in v1.5"):
model.grad_norm(2)


def test_v1_5_0_datamodule_setter():
model = BoringModel()
datamodule = BoringDataModule()
Expand Down

0 comments on commit 526a033

Please sign in to comment.