Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reference to the Trainer on the LightningDataModule #3684

Merged
merged 5 commits into from
Sep 27, 2020
Merged

Add a reference to the Trainer on the LightningDataModule #3684

merged 5 commits into from
Sep 27, 2020

Conversation

ananthsub
Copy link
Contributor

What does this PR do?

Fixes #3682
cc @nateraw

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Sep 27, 2020 •
edited
Loading

Hello @ananthsub! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-27 23:18:08 UTC

@mergify mergify bot requested a review from a team September 27, 2020 23:03
@ananthsub
Split out changes from Lightning-AI#3563 to make that PR easier to re…
4c8cd19 
…view. This formats the file according to the Black formatter
@ananthsub ananthsub force-pushed the trainer-dm branch 2 times, most recently from 1df36e8 to bb31ca7 Compare September 27, 2020 23:07
@williamFalcon williamFalcon merged commit 94c79bb into Lightning-AI:master Sep 27, 2020
@Borda Borda added the feature Is an improvement or enhancement label Sep 28, 2020
@Borda Borda added this to the 0.9.x milestone Sep 28, 2020
@nathanpainchaud nathanpainchaud mentioned this pull request Sep 28, 2020
Closed
@ananthsub ananthsub mentioned this pull request Sep 30, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.10
Development

Successfully merging this pull request may close these issues.

DataModules should have a reference to the Trainer
4 participants
@ananthsub @pep8speaks @williamFalcon @Borda