Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trainer attribute to datamodule #3749

Merged
merged 11 commits into from
Sep 30, 2020
Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Sep 30, 2020

What does this PR do?

Follow up to #3684. This adds an attribute on the datamodule for the trainer, which is later set in the training loop. It matches what's done for the lightning module: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/core/lightning.py#L92-L93

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 30, 2020 17:25
Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team September 30, 2020 17:38
@rohitgr7 rohitgr7 merged commit 1eb1d17 into Lightning-AI:master Sep 30, 2020
@Borda Borda added design Includes a design discussion data handling Generic data-related topic labels Oct 2, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic design Includes a design discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants