Rename files to avoid non-ascii characters #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames files to avoid non-ascii characters to avoid git's "precomposed unicode is not supported" error on Mac.
Any Mac user with a recent version of git will encounter the following error when they clone the
PySpice
repo and rungit status
:I called
git config core.precomposeunicode false
as suggested by the error message, and the problem disappeared. I guess all Mac users must do that when cloning PySpice.What's the cause? Apparently something weird can happen when transferring files with non-ASCII names to/from the Mac filesystem. The PySpice repo contains two files with a non-ascii character (é):
I am not knowledgeable on the subject of "precomposed" vs. "decomposed" unicode, but here are some possible solutions:
This PR just changes the file names.