-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull request for adding vehicle data #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BertoGBG
[ ] I think that there is an error in electric vehicles (passengers and trucks are in reverse order). See my comment below.
[ ] Can you also update the csv files in the output folder?
[ ] The order of magnitude of the cost for the fast charger for electric vehicles is 3 times higher than that of the slow charger.
I think this should be because, with a fast charger station, you can charge simultaneously many cars at the same time. Could you check if this is the case?
Then, I think we should add the cost of charging 1 car or add the info to the output data on the number of cars that can be charged in a fast charger.
[ ] The O&M cost for trucks is much higher than for passenger cars, I checked and the numbers are correct based on the pdf of the Fraunhofer report, @BertoGBG do you know why O&M of trucks is higher than for passenger cars?
Regarding the order of magnitude of the cost for fast charger compare to slow chargers, I am keen on thinking that the values could be correct, all included. 11kW chargers can cost 1000eur and 100kW can be 100 000 eur. For charger only with one outlet, not parallel charging. Some fast charging stations have parallel charging but they divide the current between the vehicles so the current rating is the same. However, I am not sure how the cost for fast chargers was estimated by ISE as it is about 6-500 kEur per fast charger. It is possible that they allocated to the single charger also all the costs for building the charging station and extending the grid infrastructure locally (transformers, control systems, digging, project management etc...). But I am speculating. I run into similar issues when working in the Volvo group, it was not clear who will pay for those expenses. But in a whole-society model is possible that all those costs were allocated to the chargers. I could not find reference in the English version of the study or a method description. I think that those sources are in German, maybe we can ask Sina. |
regarding O&M cost for higher for trucks and than passenger cars.
|
Ok, it makes sense to me now. |
Thanks for the additional info, I agree it is not necessarily an error and it is up the final user to decide how many fast charging stations are assumed by EV. |
Thansks @BertoGBG, IMO this is almost ready to merge, with two additions: [ ] Can you also update the csv files in the output folder? [ ] Can you add a small note to the release notes? |
Hi again @BertoGBG , I'm trying to use the cost files produced with this PR and I realized there is a bug,
should use
and the line
Otherwise, the ICE cars/trucks are not translated |
Hej @martavp I have made the change sin the file and tested it locally. The translation issue "Flssigtreibstoff" was due to the original csv file in German, in particular the letter ü which was not exported correctly in the csv file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the last additions, in my opinion, this is ready to merge.
@BertoGBG can you add a small note to the release notes?
@lisazeyen if you can take a look, we can merge this as a first step, and then, we add more updated data on costs (DEA for trucks and Bloomberg for EVs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks @BertoGBG! Just a couple of things which needs to be adjusted before the merge:
- Can you check that your version is up to date with the current master branch?
There are several technologies missing in the outputs e.g.
'CH4 (g) pipeline', 'CH4 (g) submarine pipeline', 'H2 (g) pipeline',
'H2 (g) pipeline repurposed', 'H2 (g) submarine pipeline',
'electric steam cracker', 'geothermal', 'methanol-to-kerosene',
'methanol-to-olefins/aromatics'
Maybe do a comparison of both outputs (current master branch and PR to make sure that there are only the intended changes)
-
Also I guess you changed on how many digits the values are rounded, this should stay the same as before.
-
Can we change the name of the technology "NT" to something more intuitive? I am not sure what this means.
update with vehicle cost file
updated with vehicle costs
Hej
|
outputs/costs_2020.csv
Outdated
Battery electric (trucks),FOM,14.0,%,PATHS TO A CLIMATE-NEUTRAL ENERGY SYSTEM The German energy transformation in its social context. https://www.ise.fraunhofer.de/en/publications/studies/paths-to-a-climate-neutral-energy-system.html,Battery electric (trucks) | ||
Battery electric (trucks),investment,204067.0,EUR/LKW,PATHS TO A CLIMATE-NEUTRAL ENERGY SYSTEM The German energy transformation in its social context. https://www.ise.fraunhofer.de/en/publications/studies/paths-to-a-climate-neutral-energy-system.html,Battery electric (trucks) | ||
Battery electric (trucks),lifetime,15.0,years,PATHS TO A CLIMATE-NEUTRAL ENERGY SYSTEM The German energy transformation in its social context. https://www.ise.fraunhofer.de/en/publications/studies/paths-to-a-climate-neutral-energy-system.html,Battery electric (trucks) | ||
BioSNG,C in fuel,0.32,per unit,"Stoichiometric calculation, doi:10.1016/j.apenergy.2022.120016", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the digits for the values, e.g. here 0.32
compared to what it previously was 0.324
. The values are rounded in the script to a certain value and I assume you changed the rounding to 2 digits instead of 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recreated the output files using this PR and got the 4 digits, so I'm not sure why this is happening. Maybe you open/save the files in excel @BertoGBG ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hej @lisazeyen
I realised that I didn't upload the new output files before making a pull request. Anyway I am not sure joy the rounding was changed, I never meant to.
not the output files are correct with the vehicles added and when I look at them in my GitHub they have 4 digits rounding.
I suggest you test the code locally if it does not show 4 digits.
/A
@BertoGBG Great thanks! |
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.