-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bioenergy stores with generators #1372
base: ariadne2
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…to annual-temperature-reduction
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to annual-temperature-reduction
Co-authored-by: Fabian Neumann <[email protected]>
Co-authored-by: Fabian Neumann <[email protected]>
Co-authored-by: Fabian Neumann <[email protected]>
for more information, see https://pre-commit.ci
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/psf/black-pre-commit-mirror: 24.8.0 → 24.10.0](psf/black-pre-commit-mirror@24.8.0...24.10.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Add option to reduce central heating supply temperatures annually (defaults to 1%/a)
* prepare for pypsa `0.31.0` * Update mock_snakemake (#1345) * test: log env diff (#1338) * Update mock_snakemake --------- Co-authored-by: Lukas Trippe <[email protected]> Co-authored-by: Fabian Neumann <[email protected]> * resolve other deprecations --------- Co-authored-by: Davide Fioriti <[email protected]> Co-authored-by: Fabian Neumann <[email protected]>
* [create-pull-request] automated change * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: lkstrp <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
scripts/prepare_sector_network.py
Outdated
# Set e_sum_max to the potential to limit the faux biomass transport | ||
n.generators.loc[ | ||
n.generators.carrier == "unsustainable solid biomass", "e_sum_max" | ||
] = unsustainable_solid_biomass_potentials_spatial.sum() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right constraint. There is one generator for every bus, and if every bus has access to the sum of the total potential wouldn't we get n_buses * total_potential
of import capacity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, the GlobalConstraint is just below and remains there. Then the questions if, if this e_sum_max constraint is still needed or only a duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right that it is not only redundant, but actually false. The e_sum_max set at the original generator intialization in
pypsa-eur/scripts/prepare_sector_network.py
Line 2913 in 42c262e
e_sum_max=unsustainable_solid_biomass_potentials_spatial, |
So far, you changed only the unsustainable stores to generators. Didn't we discuss with @fneum that now all Biomass stores should be changed to generators (which would save the storage constraints, and avoid the possibility that the unsustainable biomass flows through the stores due to numerical inaccuracies)? |
You are right! This was just a quick draft to resolve the solvability issues for ariadne. All other stores will be replaced in #1373. |
Closes #1336
Changes proposed in this Pull Request
As the Generator component is extended in PyPSA/PyPSA#1047, it can replace the bioenergy Store components. The extension of the Generator allows for a more efficient representation of finite resources, such as biomass, by eliminating the need for storage consistency constraints. Additionally, the desired model behavior to enforce the use of unsustainable bioenergy types is addressed through the new e_sum_min attribute.
Checklist